Improved list and feed errors #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
approved these changes
Nov 3, 2023
Comment on lines
+30
to
+37
| export enum KnownError { | ||
| FeedgenDoesNotExist, | ||
| FeedgenMisconfigured, | ||
| FeedgenBadResponse, | ||
| FeedgenOffline, | ||
| FeedgenUnknown, | ||
| Unknown, | ||
| } |
There was a problem hiding this comment.
Not a hill I'd die on, but I think we should only use string enums. These get evaluated to numbers, which makes rearranging difficult, etc.
export enum KnownError {
FeedgenDoesNotExist = 'FeedgenDoesNotExist'
...
}
Works 100% of the time, very clear.
| feed.knownError === KnownError.Unknown | ||
| ) { | ||
| return ( | ||
| <ErrorMessage message={feed.error} onPressTryAgain={onPressTryAgain} /> |
There was a problem hiding this comment.
Hehe so we fall back to the red error?
There was a problem hiding this comment.
Hah ya but only for non-feedgens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedgen errors
List error state