Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup did for my profile at screen to avoid bad actor error #1800

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Nov 3, 2023

Users who tap the "Profile" footer button while loading sometimes receive an error message that can't be replaced. This is because the DID is being passed to the profile screen via the initial params in the navigator, and if they press the button before loading finishes then it may be undefined at time of press.

This PR solves that by looking up the DID within the screen. If they happen to press it early, they'll briefly get the error, then it will correct itself.

@pfrazee pfrazee merged commit 846c130 into main Nov 3, 2023
4 checks passed
@pfrazee pfrazee deleted the fix-bad-actor-profile-tab branch November 3, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants