Restore autofocus on emoji drop down #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works correctly on Firefox, Chrome, and Safari. @pfrazee I will leave merging up to you as this change auto-focuses the search bar when the emoji picker is opened, which is a UX question |
pfrazee
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okey, I know somebody must have explicitly turned this feature off by stating
autoFocus={false}in theEmojiPicker, but as an end user it feels really weird to me not to have this auto-focus (I realized several time I was typing my search query directly in the post's content).Maybe there is a good reason it was deactivated in one specific scenario? At least on my standard desktop browser I believe autofocus is a nicer UX.