Extract shell state into separate context #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
commented
Nov 6, 2023
src/state/shell/index.tsx
Outdated
Comment on lines
34
to
39
| minimalShellMode, | ||
| setMinimalShellMode: _setMinimalShellMode, | ||
| isDrawerOpen, | ||
| setIsDrawerOpen: _setIsDrawerOpen, | ||
| isDrawerSwipeDisabled, | ||
| setIsDrawerSwipeDisabled: _setIsDrawerSwipeDisabled, |
There was a problem hiding this comment.
Could create callbacks for each of these too
estrattonbailey
commented
Nov 6, 2023
| @@ -38,7 +38,7 @@ export const FeedPage = observer(function FeedPageImpl({ | |||
| const store = useStores() | |||
| const pal = usePalette('default') | |||
| const {isDesktop} = useWebMediaQueries() | |||
| const [onMainScroll, isScrolledDown, resetMainScroll] = useOnMainScroll(store) | |||
| const [onMainScroll, isScrolledDown, resetMainScroll] = useOnMainScroll() | |||
There was a problem hiding this comment.
No longer need to pass in the root store
estrattonbailey
commented
Nov 6, 2023
Comment on lines
+53
to
62
| let listener = {remove() {}} | ||
| if (isAndroid) { | ||
| listener = BackHandler.addEventListener('hardwareBackPress', () => { | ||
| setIsDrawerOpen(false) | ||
| return store.shell.closeAnyActiveElement() | ||
| }) | ||
| } | ||
| return () => { | ||
| listener() | ||
| listener.remove() | ||
| } |
There was a problem hiding this comment.
Needed to use useShellState, so refactored this logic up a level into the component 👍
estrattonbailey
commented
Nov 6, 2023
src/view/shell/index.web.tsx
Outdated
Comment on lines
31
to
32
| setIsDrawerOpen(false) | ||
| store.shell.closeAnyActiveElement() |
There was a problem hiding this comment.
Need to do this here instead of in a centralized closeAnyActiveElement. We will migrate this later on.
gaearon
requested changes
Nov 7, 2023
| @@ -38,7 +39,7 @@ export function useMinimalShellMode() { | |||
|
|
|||
| React.useEffect(() => { | |||
| return autorun(() => { | |||
There was a problem hiding this comment.
The autorun here doesn't make sense anymore.
gaearon
reviewed
Nov 7, 2023
pfrazee
deleted the
eric/app-906-extract-shell-state-into-separate-statecontext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out drawer handling and minimal shell mode into its own React context provider and methods.
Couple notes: