Move onboarding state to new persistence + reducer context #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
approved these changes
Nov 8, 2023
| @@ -9,6 +9,7 @@ import {cleanError} from 'lib/strings/errors' | |||
| import {getAge} from 'lib/strings/time' | |||
| import {track} from 'lib/analytics/analytics' | |||
| import {logger} from '#/logger' | |||
| import {DispatchContext as OnboardingDispatchContext} from '#/state/shell/onboarding' | |||
Comment on lines
+10
to
+12
| handle: z.string().optional(), | ||
| displayName: z.string().optional(), | ||
| aviUrl: z.string().optional(), |
There was a problem hiding this comment.
If our plan is to fetch this data to render screens that need it, should we just remove these entirely and only store the bare minimum in storage?
There was a problem hiding this comment.
that might be better yeah
src/state/shell/onboarding.tsx
Outdated
There was a problem hiding this comment.
When we update onboarding, we should be able to localize this state a little more since the rest of the app doesn't really need to be aware of onboarding state, aside from the kinda boolean "is onboarding complete/active or not" we may need elsewhere
pfrazee
force-pushed
the
onboarding-persist-update
branch
from
987614f to
3893acc
Compare
estrattonbailey
added a commit
that referenced
this pull request
Nov 8, 2023
…-state-into-separate-statecontext * origin: Move invite-state to new persistence + context and replace the notifications with just showing uses in the modal (#1840) Move muted threads to new persistence + context (#1838) Move onboarding state to new persistence + reducer context (#1835) Move require alt-text to new persistence + context (#1839) Move reminders to new persisted state layer (#1834) Add persistent state provider (#1830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors onboarding state away from the mobx model and into reducer contexts which use the new persistence layer