Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move require alt-text to new persistence + context #1839

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Nov 8, 2023

No description provided.

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but question on file location — can happen later too nbd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be shell state or preferences?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally preferences - I just put it here for convenience since the other waiting PR adds preferences

@pfrazee pfrazee merged commit 3a21101 into main Nov 8, 2023
4 checks passed
@pfrazee pfrazee deleted the alt-text-required-persistence-update branch November 8, 2023 16:52
estrattonbailey added a commit that referenced this pull request Nov 8, 2023
…-state-into-separate-statecontext

* origin:
  Move invite-state to new persistence + context and replace the notifications with just showing uses in the modal (#1840)
  Move muted threads to new persistence + context (#1838)
  Move onboarding state to new persistence + reducer context (#1835)
  Move require alt-text to new persistence + context (#1839)
  Move reminders to new persisted state layer (#1834)
  Add persistent state provider (#1830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants