Fix initial pager gap after fast scroll #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the new pager sync scrolling logic I've added in #1863.
The previous code was saying: "sync scroll only if we didn't scroll past the header". The problem is that if we scroll fast, we're gonna have a large gap between the last event (which didn't reach the limit, but got synced) and the next event (which went over the limit, and didn't get synced).
Instead, let's track the last value that got synced. During every scroll, we'll calculate the new target, applying the limit. If we need to sync up the scroll, we'll do so and store the current value as the last one that got synced.
As a result, if we get an event that "overshoots" the header hiding threshold, we'll still adjust other pages to be exactly at that limit.
Test Plan
Flicking one of the tabs down really fast no longer causes a blank space on other tabs.