Refactor profile screen to use new pager and react-query #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
force-pushed
the
profile-tabs
branch
from
036fc3e to
fd7c39e
Compare
pfrazee
force-pushed
the
profile-tabs
branch
from
aab5ee7 to
ef2d504
Compare
pfrazee
changed the title
gaearon
commented
Nov 13, 2023
| useEffect(() => { | ||
| // dont fire on first run to avoid needless re-renders | ||
| if (!firstRun.current) { | ||
| setState({ts: Date.now(), value: fromProfile(profile)}) |
There was a problem hiding this comment.
Can you describe how you want this to work? Generally we shouldn't be setting state from effects. If there's a need to adjust state, the canonical way is to do this. But I think I'm not quite following the logic in general so I want to understand the intended behavior.
| firstRun.current = false | ||
| }, [profile]) | ||
|
|
||
| return state.ts > ifAfterTS ? mergeShadow(profile, state.value) : profile |
There was a problem hiding this comment.
We should probably useMemo this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<PagerWithHeader>Still todo in followup PRs: