Factor our feed source model #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
commented
Nov 13, 2023
Comment on lines
+5
to
+24
| export function useLikeMutation() { | ||
| const {agent} = useSession() | ||
|
|
||
| return useMutation({ | ||
| mutationFn: async ({uri, cid}: {uri: string; cid: string}) => { | ||
| const res = await agent.like(uri, cid) | ||
| return {uri: res.uri} | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| export function useUnlikeMutation() { | ||
| const {agent} = useSession() | ||
|
|
||
| return useMutation({ | ||
| mutationFn: async ({uri}: {uri: string}) => { | ||
| await agent.deleteLike(uri) | ||
| }, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Figured some generic helpers might be good?
estrattonbailey
commented
Nov 13, 2023
Comment on lines
+20
to
+23
| const res = await agent.app.bsky.feed.getSuggestedFeeds({ | ||
| limit: 10, | ||
| cursor: pageParam, | ||
| }) |
There was a problem hiding this comment.
We only return 10 right now regardless, but in the future we may actually paginate
estrattonbailey
commented
Nov 13, 2023
| @@ -23,7 +22,7 @@ import { | |||
| } from '#/state/queries/preferences' | |||
| import {useFeedSourceInfoQuery} from '#/state/queries/feed' | |||
|
|
|||
| export const NewFeedSourceCard = observer(function FeedSourceCardImpl({ | |||
| export const FeedSourceCard = observer(function FeedSourceCardImpl({ | |||
There was a problem hiding this comment.
Had built a new version alongside the old. Replaced last old version with new and renamed.
estrattonbailey
commented
Nov 13, 2023
Comment on lines
+76
to
+80
| <FeedSourceCard | ||
| feedUri={embed.record.uri} | ||
| style={[pal.view, pal.border, styles.customFeedOuter]} | ||
| showLikes | ||
| /> |
There was a problem hiding this comment.
Portable, only needs a URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.