Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer update (react-query refactor) #1899

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Composer update (react-query refactor) #1899

merged 3 commits into from
Nov 14, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Nov 14, 2023

  • Moves composer state to a context
  • Reworks the composer to use RQ

Notes

  • I kept two mobx models which are used for the image galleries. They don't touch the rootstore god object. If we don't get to them during this refactor we can survive; just trying to keep us moving.
  • I had to create a non-RQ autocomplete class to interact with tiptap. Cest la vie.

pfrazee and others added 3 commits November 14, 2023 09:36
@pfrazee
Move composer state to a context
a78a12c
@pfrazee
Rework composer to use RQ
866178c
@estrattonbailey
Merge remote-tracking branch 'origin' into composer-rq
f71003b 
* origin:
  Fix poll latest loop (#1901)
  Handle end of feed (#1898)
  Refactor onboarding suggested follows (#1897)
  Update Muted and Blocked accounts screens (react-query refactor) (#1892)
estrattonbailey
estrattonbailey approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

src/state/models/media/gallery.ts
rootStore: false,
})
constructor() {
makeAutoObservable(this)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@pfrazee pfrazee merged commit 0a26e78 into main Nov 14, 2023
3 of 4 checks passed
@pfrazee pfrazee deleted the composer-rq branch November 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estrattonbailey estrattonbailey estrattonbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfrazee @estrattonbailey