Fix self mention, resolve handle #1903
Merged
+46
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin: Fix root sibling context issue (#1902)
estrattonbailey
commented
Nov 14, 2023
src/state/queries/handle.ts
Outdated
Comment on lines
16
to
17
| // cache in memory forever, page reload clears | ||
| staleTime: Infinity, |
There was a problem hiding this comment.
we should invalidate the cache when the user changes their handle, and might want to manually update the cache any time we use the get profile hook
pfrazee
approved these changes
Nov 14, 2023
src/state/queries/handle.ts
Outdated
Comment on lines
16
to
17
| // cache in memory forever, page reload clears | ||
| staleTime: Infinity, |
There was a problem hiding this comment.
we should invalidate the cache when the user changes their handle, and might want to manually update the cache any time we use the get profile hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces logic with new patterns, adds a couple new utils for getting a
handlebyhandleOrDid. Prev handling was synchronous, new is async, so I added a disabled state to this button.