Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-reactive callbacks for some methods #1948

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Use non-reactive callbacks for some methods #1948

merged 3 commits into from
Nov 17, 2023

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 17, 2023

Opening the lightbox in profile no longer re-renders the profile header.
Opening the composer in feed no longer re-renders the feed.

Plus a driveby simplification.

@gaearon gaearon changed the title Use non-reactive callbacks for some methods @gaearon Use non-reactive callbacks for some methods Nov 17, 2023
@gaearon gaearon requested a review from pfrazee November 17, 2023 04:32
@pfrazee pfrazee merged commit a8aed2c into main Nov 17, 2023
3 of 4 checks passed
@pfrazee pfrazee deleted the optimize-cb branch November 17, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants