Fix some key errors #1951
Merged
Fix some key errors #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Nov 17, 2023
| @@ -75,7 +75,12 @@ export function ProfileLists({ | |||
| items = items.concat([EMPTY]) | |||
| } else if (data?.pages) { | |||
| for (const page of data?.pages) { | |||
| items = items.concat(page.lists) | |||
| items = items.concat( | |||
There was a problem hiding this comment.
Do we have other places needing a similar fix?
There was a problem hiding this comment.
Haven't noticed any yet, just grouped these fixes in a pr for now
gaearon
reviewed
Nov 17, 2023
| // dedupe | ||
| friendsOfFriends.filter(f => !friends.find(f2 => f.did === f2.did)), | ||
| const deduped = friendsOfFriends.filter( | ||
| (f, i) => friendsOfFriends.findIndex(f2 => f.did === f2.did) === i, |
There was a problem hiding this comment.
Can we do Array.from(new Set(friendsOfFriends)) to avoid loops inside a loop?
There was a problem hiding this comment.
Not with objects, but we could probably do this faster by creating a Set(did, obj) and reading values.
gaearon
approved these changes
Nov 17, 2023
|
Just gonna merge this and continue in a sep PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.