Optimize notifications rendering #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
approved these changes
Nov 17, 2023
Hartaithan
reviewed
Nov 18, 2023
| @@ -56,15 +56,15 @@ interface Author { | |||
| moderation: ProfileModeration | |||
| } | |||
|
|
|||
| export function FeedItem({ | |||
| let FeedItem = ({ | |||
There was a problem hiding this comment.
hi, i'm just stranger
but can you explain this approach, please? interesting
why you need to store component in let variable and apply memo later, instead of just wrapping component in memo?
There was a problem hiding this comment.
wow, i doesn't know that every stranger can comments on pr's like that
if i'm not allowed to, please excuse me
There was a problem hiding this comment.
There was a problem hiding this comment.
It doesn't really matter, I just want to avoid an extra indentation level in the code.
|
To people getting excited by this PR — this just returns us to the baseline perf we had before a bunch of refactors. So this won't by itself make anything faster, it just avoids us making things slow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Scrolling notifications with 6x CPU throttling: 700ms stall.
After
Scrolling notifications with 6x CPU throttling: 30ms stall.