Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nsfw feeds in public view #2035

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Handle nsfw feeds in public view #2035

merged 10 commits into from
Nov 30, 2023

Conversation

estrattonbailey
Copy link
Member

No description provided.

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we just add a check in the feed-query for nsfw labels if you're signed out and throw an error if you are? Then the KnownError handler could pick it up and render what you're trying to do.

* origin:
  Disable retrying globally (#2038)
  Slightly less verbose variable
  Update home-screen tests related to feeds
  Stop adding whats-hot for new users
  Conditionally render feeds link in feeds tab bar
  Add hasPinnedCustomFeedOrList to usePinnedFeedsInfos hook
  Add pinOnSave and use it in discover feeds list
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks for going rounds with me on this one

@pfrazee pfrazee merged commit b83fa95 into main Nov 30, 2023
4 checks passed
@pfrazee pfrazee deleted the eric/feeds-handling branch November 30, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants