Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EAS managed build number, run build/submit on GH Actions #2841

Merged
merged 21 commits into from
Feb 21, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Feb 12, 2024

This creates a better workflow for building and deploying. Also does automatic nightly TestFlights for iOS

  • Use GitHub runners for deployments instead of EAS. iOS runs on macos-14 and Android runs on ubuntu-latest.
  • Use EAS's remove build number instead of saving locally to app.config.js. This eliminates the need for committing to the repo each time we deploy to TestFlight.
  • The iOS job runs either manually or automatically each night at 9PM PST. The Android job only runs manually.
  • Both jobs automatically deploy to the store after building. (Build times for both platforms average 15 minutes)
  • On both platforms we obtain the Sentry auth tokens from a GitHub secret. On Android google-services.json is also obtained from another GitHub secret.

@haileyok haileyok marked this pull request as ready for review February 12, 2024 05:12
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing, should be easy to resolve

app.config.js Outdated Show resolved Hide resolved
try again

try again

try again

try again

add same for android

maybe now

omg wow i messed that up?

once again

once again

again

error?

add caching

add caching

try again again again again

try again again again

try again again

try again

try this a different way

another test

testing this again
@haileyok haileyok force-pushed the hailey/use-eas-version-code branch from b427987 to 8465cca Compare February 16, 2024 01:51
@haileyok haileyok marked this pull request as draft February 16, 2024 05:11
@haileyok haileyok changed the title Use EAS managed build number Use EAS managed build number, run build/submit on GH Actions Feb 21, 2024
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's give it a go 🎉

@haileyok haileyok marked this pull request as ready for review February 21, 2024 21:54
@haileyok haileyok merged commit 874489b into main Feb 21, 2024
4 checks passed
estrattonbailey added a commit that referenced this pull request Feb 26, 2024
* origin/main: (69 commits)
  Update .po files
  use `showControls` to show/hide live text icon on ios (#2982)
  Fix dim mode unread notif color
  Make dim theme dim (#2966)
  Add handle validation to create account UI (#2959)
  Normalize relative day (#2874)
  increase timeout to 15s (#2958)
  use `useOpenLink` hook for links in ALF (#2975)
  Rename Home Feed Prefs to Following Feed Prefs (#2965)
  Refactor feed header components (#2964)
  patch react-navigation to fix history bug (#2955)
  Use EAS managed build number, run build/submit on GH Actions (#2841)
  Fix `numberOfLines` not updating on iOS 15 (#2956)
  Fix UITextView line height adjustment for DynamicType, always use the max width for the view (#2916)
  Navigate back from a deleted post's route (#2948)
  Add optional close callback to Dialog (#2947)
  Fix flash when pressing into just-created post (#2945)
  Last usage (#2944)
  Update blogpost URL in ExportCarDialog.tsx (#2939)
  Prefer full posts for post thread placeholder (#2943)
  ...
@haileyok haileyok deleted the hailey/use-eas-version-code branch June 8, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants