Fabric migration - @react-native-community/datetimepicker -> react-native-date-picker
#3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing requires building a client after checking out #3096
This PR replaces
@react-native-community/datetimepickerwithreact-native-date-picker. The former is not compatible with Fabric.Note: An unrelated issue to this PR that we need to fix is that the timezones are not maintained between the picker and the displayed date. This is obvious during user onboarding, whenever a user picks their date of birth that should put them at 18, but actually results in them being 17 and 364 days old 🫠 - Update this is fixed!
Test Plan