Fabric migration - Testing new arch #3106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing tests remove other `react-native-fs` usages move to `expo-image-manipulator` for resizes remove react-native-image-resizer update tests update jest setup simplify some logic properly cleanup files migrate file downloads to `expo-file-system` rm `rn-fetch-blob`
…on-pt7 # Conflicts: # package.json
This reverts commit 369ab09.
haileyok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on #3096 and all of its related PRs. Do not merge this PR until that PR is merged into main.
This PR is going to get messy, it's an experiment to see what exactly we need to replace/remove/change/leave alone when using Fabric on iOS. Fabric on Android was much less finicky, so I'm going to target iOS and then make adjustments as needed for Android.
Once I get a decent gameplan, I'll open a separate branch and make individual changes to that branch to keep track of things. For now its all living in my head, a Trello board, and a Notion document...
Test Plan
To be determined...
To Test
You can check your
Podfile.lockinside of the iOS directory for the keywordfabric. There should be anRCTFabricentry.You can also see if Fabric is enabled by running a
pod installmanually. you should see[Codegen] Donenear the bottom.After testing, you will need to nuke again. The
newArchEnabledflag likes to "stick" even if you just remove it from the config and do a prebuild again, so it's best to nuke and start from scratch.