By default, hide replies to people you don't follow in the Following feed #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
changed the title
estrattonbailey
approved these changes
Mar 6, 2024
pfrazee
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement to bluesky-social/atproto#2279.
It has been a pretty common complaint that the Following feed becomes unusable when someone you follow goes on a reply spree because we're showing every single reply by default. This changes so that by default (if you haven't expressed a preference), we're going to show a reply if you follow both people in the conversation.
People who have expressed a particular preference will keep it.
Test Plan
Create a new user or take an existing one who hasn’t changed this setting. Observe that their default preferences have the "Reply Filters" toggle on whereas previously they wouldn’t.
See the behavior difference below.
Also verified that if you explicitly chose a setting, your preference remains respected.
Before
A user who hasn't changed the setting would see replies to people they don't follow in their Following feed.
following_before.mov
After
A user who hasn't changed their setting would see only reply chains to people they follow in their Following feed.
following_after.mov