Fix lineHeight problems on native with new Text
#3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
approved these changes
Mar 11, 2024
estrattonbailey
added a commit
that referenced
this pull request
Mar 12, 2024
* origin/main: Unwrap Menu.Trigger on web (#3182) move imports to top move button inline if viewport is small (vertically) Update po files Fix onboarding `FeedCard` text overflow (#3176) Fix `lineHeight` problems on native with new `Text` (#3175) only include `localhost:19006` as intent filter on android (#3167) await `share` before closing menu (#3173)
estrattonbailey
added a commit
that referenced
this pull request
Mar 12, 2024
…on-2 * origin/main: Small fixes (#3184) Combine actions, convert to new menu (#3174) Convert profile edit avatar/banner dropdown menus to new menu (#3177) Save image to user media library when taken from camera during composing (#3180) Dedupe navigation events (push, navigate, pop, etc) (#3179) Unwrap Menu.Trigger on web (#3182) move imports to top move button inline if viewport is small (vertically) Update po files Fix onboarding `FeedCard` text overflow (#3176) Fix `lineHeight` problems on native with new `Text` (#3175) only include `localhost:19006` as intent filter on android (#3167) await `share` before closing menu (#3173) Fix button widths in the Settings on web (#3165) Fix font styles on web (#3162) Fix `aria-label` on the Share button (#3159) Fix RSS URLs treated as internal (#3156) Poll Statsig for config changes (#3158) Fix missing check for invite code (#3157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On native, setting the
lineHeightto thefontSizeadds a bit of extra height that we don't want, preventing us from properly aligning text in some cases. Instead, let's only apply that on web (during testing, it does seem to help on web to do this). On native, if the line height is undefined or zero, don't change it.Before
After