Save image to user media library when taken from camera during composing

[haileyok]

Simple one here. Saves pics taken with the camera to the media library as well when composing a post.

[surfdude29]

Apologies for jumping in (yet again), I'm wondering: does {saveImageToMediaLibrary} automatically take care of camera roll/photo gallery permissions if the user hasn't granted that? Sorry if it's a stupid question

[haileyok]

It actually should (for me it worked fine on Android) but there's no harm in checking again (might not work on iOS).

Besides, I think it make more sense to access MediaLibrary directly here and prevent any dupes, we can just move all the logic into here to handle it. So yup, we'll handle the perms calls here.

[surfdude29]

Sounds sensible to me (but you obviously know much more about these things than I do :) The thought occurred as I know Camera and Photos are separate permissions on iOS (I don't have any experience with Android) and when I just tested on a fresh install of the current app, taking a photo prompted for Camera permission but not Photos (I realise it's not saving Camera images atm of course).

And sorry for the annoying questions btw, thank you for being so friendly and patient in answering and explaining to someone who's very much a newbie 🙏

[haileyok]

Feel free! They actually are not the same permission! Simulator didn't error besides telling me there was no camera so first check looked good, but ended up not working on the device build.

We should actually probably move the logic for checking perms right into these helper functions rather than having to do do the perms check logic each time we call openCamera() or openImagePicker() and prevent forgetting to do it. Something for another time though 😅

[surfdude29]

We should actually probably move the logic for checking perms right into these helper functions rather than having to do do the perms check logic each time we call openCamera() or openImagePicker() and prevent forgetting to do it. Something for another time though 😅

Yeah I know you all have a long enough TODO list as is 😅