Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian Localization #3388

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Italian Localization #3388

merged 7 commits into from
Apr 9, 2024

Conversation

Titianbeetle
Copy link
Contributor

New strings translated for v.1.75

New strings translated for v.1.75
@pfrazee
Copy link
Collaborator

pfrazee commented Apr 4, 2024

@Titianbeetle can you get a second italian speaker to review this? We always want a confirmation

@pfrazee pfrazee added intl Internationalization intl-needs-confirmation Submitted internationalization that needs confirmations by native speakers. labels Apr 4, 2024
Changed two expressions following the revision of @marcomaroni
@Titianbeetle
Copy link
Contributor Author

@pfrazee I am in a bit of a pickle here! @marcomaroni came in as a second participant and did a few corrections (see https://github.com/Titianbeetle/social-app/commit/71bdb7b806b806e8aab3013b097f2a28e9de69c4 ,which I have implemented. However, for reason beyond my jurisdiction, his account has been cancelled by GitHub (go figure!) so I am bit stuck as I cannot find any other Italian speaker available on this platform. Also, there is now an error in the check which wasn't there early and I have no idea what caused it. I will put out a call to see if someone else is willing to help and if not I may put an end to my stint as volunteer translator :(

Additional changes to text applied following the suggestion of external translators.
@surfdude29
Copy link
Contributor

surfdude29 commented Apr 5, 2024

Also, there is now an error in the check which wasn't there early and I have no idea what caused it.

I don't think you need to worry about the PR labeler / webpack-analyzer error, I got that too on my PR. I might be wrong on this but I think that is only applicable for Bluesky team members?

@haileyok
Copy link
Contributor

haileyok commented Apr 5, 2024

Heh yea, the labeler is a bit wonky when working with other people's PRs. I disabled it for external contributors now, so if you merge in main it should stop yelling at you.

Deleted extra stop and corrected a gramatical error
Added a correction on string 414 which had a grammatical error.
String with Labeler updated.
Additional changes made to wordings in traduced strings
@pfrazee
Copy link
Collaborator

pfrazee commented Apr 9, 2024

@pfrazee I am in a bit of a pickle here!

Oh dear! Okay well I'll take that as sufficient. Hope their account gets sorted out, and thanks for everything!

@pfrazee pfrazee merged commit edab3d2 into bluesky-social:main Apr 9, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request Apr 12, 2024
* origin/main: (455 commits)
  Use getSuggestions endpoint behind the gate (#3499)
  Added `new_profile_scroll_component` to `Gate` type (#3487)
  Fix useGate lint rule (#3486)
  Make bio area scrollable on iOS (#2931)
  Improve Android haptic, offer toggle for haptics in the app (#3482)
  Search - only enable queries once tab is active (#3471)
  [Statsig] Mark Testflight as staging tier (#3470)
  [Statsig] Typecheck gates (#3467)
  Bump to 1.77 (#3468)
  Search - extra tabs (#3408)
  notify slack on production builds (#3461)
  notify slack on production builds (#3460)
  1.76 release preparations (#3459)
  Update zh-CN translation (#3433)
  Italian Localization (#3388)
  [Statsig] Send prev route name (#3456)
  [Statsig] Instrument feed display (#3455)
  Small logic cleanups (#3449)
  Use ALF for the embed consent modal (#3336)
  Onboarding tweaks (#3447)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intl Internationalization intl-needs-confirmation Submitted internationalization that needs confirmations by native speakers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants