[Remove Font Awesome] Cleanup unused icons, replace a few more icons with the new icon library #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few of the remaining icons in |
|
mozzius
reviewed
Apr 8, 2024
| @@ -433,7 +435,7 @@ export function FeedsScreen(_props: Props) { | |||
| href="/settings/saved-feeds" | |||
| accessibilityLabel={_(msg`Edit My Feeds`)} | |||
| accessibilityHint=""> | |||
| <CogIcon strokeWidth={1.5} style={pal.icon} size={28} /> | |||
| <Gear style={pal.textLight} size="lg" /> | |||
There was a problem hiding this comment.
Should be pal.icon, otherwise there's a mismatch with the icon next to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another continuation of #3438 stacked on #3440. This just cleans up some of the now unused icons, as well as a few other pieces of cleanup.
Test Plan
Icons were replaced in the settings screen. Verified that the hashtag icon and the raised hand icon still look correct in that screen.
Also verified that the replaced
CogIconin the feeds screen looks correct.