[Embeds] Embed for single post #3450
Conversation
|
|
Image embeds
|
|
external embed
|
|
Quote post (+ with media)
|
|
Lists and feeds |
|
PWI opt out
|
bskyembed/src/embed.tsx
Outdated
|
|
||
| // Case 3.6: Post blocked | ||
| if (AppBskyEmbedRecord.isViewBlocked(record)) { | ||
| return <Info>The quoted post is blocked</Info> |
There was a problem hiding this comment.
Do we want to give more context on what "blocked" means? Might be confusing for someone who doesn't use Bluesky, but idk.
There was a problem hiding this comment.
Yeah, I went back and forth on this but I wasn't able to summarise the rather complex behaviour at play here 😅 open to suggestions
There was a problem hiding this comment.
Ha yea notice I didn't give a suggestion 😅 not really sure how to word this either based on the actual behavior but also trying to be relatively simple for outsiders.
bskyembed/src/embed.tsx
Outdated
| if (pwiOptOut) { | ||
| return ( | ||
| <Info> | ||
| The author of this quoted post has requested their posts not be |
There was a problem hiding this comment.
Can the locale be configured via the embed? Or is the locale of the post gonna be used?
There was a problem hiding this comment.
Good question, I'll add to the trello
mozzius
force-pushed
the
samuel/embeds-2
branch
from
14f42c0 to
3505c59
Compare
mozzius
force-pushed
the
samuel/embeds-2
branch
2 times, most recently
from
05fe8b9 to
65bca74
Compare
* add CTA, colourful icons, and bigger logo * make hover effect smaller + add to cta
mozzius
force-pushed
the
samuel/embeds-2
branch
from
65bca74 to
b596393
Compare
Stacked on #3448
This PR adds support for embedding a single post. It takes an AT URI in the search parameters, and supports rich text and embeds
Test plan
cd bskyembedandyarn dev)?uri=<at-uri>to the query string (i.e.http://localhost:5173/?uri=at://did:plc:wqwdm7xgynf7amclnjfhvncr/app.bsky.feed.post/3kpvyeesjry2o)