[Statsig] Instrument feed display #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haileyok
reviewed
Apr 9, 2024
Comment on lines
+100
to
+109
| useFocusEffect( | ||
| useNonReactiveCallback(() => { | ||
| logEvent('home:feedDisplayed', { | ||
| index: selectedIndex, | ||
| feedType: selectedFeed.split('|')[0], | ||
| feedUrl: selectedFeed, | ||
| reason: 'focus', | ||
| }) | ||
| }), | ||
| ) |
There was a problem hiding this comment.
cool. i remember you making this suggestion for these cases, glad to see it in action!
pfrazee
approved these changes
Apr 9, 2024
estrattonbailey
added a commit
that referenced
this pull request
Apr 12, 2024
* origin/main: (455 commits) Use getSuggestions endpoint behind the gate (#3499) Added `new_profile_scroll_component` to `Gate` type (#3487) Fix useGate lint rule (#3486) Make bio area scrollable on iOS (#2931) Improve Android haptic, offer toggle for haptics in the app (#3482) Search - only enable queries once tab is active (#3471) [Statsig] Mark Testflight as staging tier (#3470) [Statsig] Typecheck gates (#3467) Bump to 1.77 (#3468) Search - extra tabs (#3408) notify slack on production builds (#3461) notify slack on production builds (#3460) 1.76 release preparations (#3459) Update zh-CN translation (#3433) Italian Localization (#3388) [Statsig] Send prev route name (#3456) [Statsig] Instrument feed display (#3455) Small logic cleanups (#3449) Use ALF for the embed consent modal (#3336) Onboarding tweaks (#3447) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event that fires when a feed is displayed, along with the index and the reason. It was a bit tricky to figure out the right place to thread these through. This is the minimally invasive way I've found.
Test Plan
Add
console.logtologEventinstatsig.tsx.You should see events firing according to the schema.