Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useGate lint rule #3486

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix useGate lint rule #3486

merged 1 commit into from
Apr 11, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 11, 2024

Fixes false positive firing on main because #2931 imports it from lib/....

Let's just explicitly disallow imports starting with statsig or @statsig that refer to npm packages.

@gaearon gaearon requested a review from haileyok April 11, 2024 22:54
@gaearon gaearon merged commit 491116c into main Apr 11, 2024
5 of 6 checks passed
Copy link

Old size New size Diff
6.36 MB 6.36 MB 0 B (0.00%)

@gaearon gaearon deleted the fix-statsig-lint branch April 11, 2024 22:59
estrattonbailey added a commit that referenced this pull request Apr 12, 2024
* origin/main: (455 commits)
  Use getSuggestions endpoint behind the gate (#3499)
  Added `new_profile_scroll_component` to `Gate` type (#3487)
  Fix useGate lint rule (#3486)
  Make bio area scrollable on iOS (#2931)
  Improve Android haptic, offer toggle for haptics in the app (#3482)
  Search - only enable queries once tab is active (#3471)
  [Statsig] Mark Testflight as staging tier (#3470)
  [Statsig] Typecheck gates (#3467)
  Bump to 1.77 (#3468)
  Search - extra tabs (#3408)
  notify slack on production builds (#3461)
  notify slack on production builds (#3460)
  1.76 release preparations (#3459)
  Update zh-CN translation (#3433)
  Italian Localization (#3388)
  [Statsig] Send prev route name (#3456)
  [Statsig] Instrument feed display (#3455)
  Small logic cleanups (#3449)
  Use ALF for the embed consent modal (#3336)
  Onboarding tweaks (#3447)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants