-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebased embedr #3511
Merged
Merged
rebased embedr #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
bnewbold/embedr-rebase
branch
from
April 13, 2024 03:05
80fccba
to
9108789
Compare
The Pull Request introduced fingerprint changes against the base commit: 1a9eeb7 Fingerprint diff[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"63035687a5b971d3fb4d0f9b01a3b55b1101dc96"},{"type":"contents","id":"packageJson:scripts","contents":"{\"prepare\":\"is-ci || husky install\",\"postinstall\":\"patch-package && yarn intl:compile\",\"prebuild\":\"expo prebuild --clean\",\"android\":\"expo run:android\",\"ios\":\"expo run:ios\",\"web\":\"expo start --web\",\"use-build-number\":\"./scripts/useBuildNumberEnv.sh\",\"use-build-number-with-bump\":\"./scripts/useBuildNumberEnvWithBump.sh\",\"build-web\":\"expo export:web && node ./scripts/post-web-build.js && cp -v ./web-build/static/js/*.* ./bskyweb/static/js/\",\"build-all\":\"yarn intl:build && yarn use-build-number-with-bump eas build --platform all\",\"build-ios\":\"yarn use-build-number-with-bump eas build -p ios\",\"build-android\":\"yarn use-build-number-with-bump eas build -p android\",\"build\":\"yarn use-build-number-with-bump eas build\",\"build-embed\":\"cd bskyembed && yarn build && yarn build-snippet && cd .. && node ./scripts/post-embed-build.js\",\"start\":\"expo start --dev-client\",\"start:prod\":\"expo start --dev-client --no-dev --minify\",\"clean-cache\":\"rm -rf node_modules/.cache/babel-loader/*\",\"test\":\"NODE_ENV=test jest --forceExit --testTimeout=20000 --bail\",\"test-watch\":\"NODE_ENV=test jest --watchAll\",\"test-ci\":\"NODE_ENV=test jest --ci --forceExit --reporters=default --reporters=jest-junit\",\"test-coverage\":\"NODE_ENV=test jest --coverage\",\"lint\":\"eslint --cache --ext .js,.jsx,.ts,.tsx src\",\"typecheck\":\"tsc --project ./tsconfig.check.json\",\"e2e:mock-server\":\"./jest/dev-infra/with-test-redis-and-db.sh ts-node --project tsconfig.e2e.json __e2e__/mock-server.ts\",\"e2e:metro\":\"NODE_ENV=test RN_SRC_EXT=e2e.ts,e2e.tsx expo run:ios\",\"e2e:build\":\"NODE_ENV=test detox build -c ios.sim.debug\",\"e2e:run\":\"NODE_ENV=test detox test --configuration ios.sim.debug --take-screenshots all\",\"perf:test\":\"NODE_ENV=test maestro test\",\"perf:test:run\":\"NODE_ENV=test maestro test __e2e__/maestro/scroll.yaml\",\"perf:test:measure\":\"NODE_ENV=test flashlight test --bundleId xyz.blueskyweb.app --testCommand \\\"yarn perf:test\\\" --duration 150000 --resultsFilePath .perf/results.json\",\"perf:test:results\":\"NODE_ENV=test flashlight report .perf/results.json\",\"perf:measure\":\"NODE_ENV=test flashlight measure\",\"intl:build\":\"yarn intl:extract && yarn intl:compile\",\"intl:extract\":\"lingui extract\",\"intl:compile\":\"lingui compile\",\"nuke\":\"rm -rf ./node_modules && rm -rf ./ios && rm -rf ./android\",\"update-extensions\":\"bash scripts/updateExtensions.sh\",\"export\":\"npx expo export\",\"make-deploy-bundle\":\"bash scripts/bundleUpdate.sh\",\"generate-webpack-stats-file\":\"EXPO_PUBLIC_GENERATE_STATS=1 yarn build-web\",\"open-analyzer\":\"EXPO_PUBLIC_OPEN_ANALYZER=1 yarn build-web\"}","reasons":["packageJson:scripts"],"hash":"edfe8011ff2ca3199e3d9cc7d1220d58471966e9"}] Generated by PR labeler 🤖 |
|
gaearon
force-pushed
the
bnewbold/embedr-rebase
branch
4 times, most recently
from
April 13, 2024 11:45
e54add0
to
7a8ddd6
Compare
gaearon
force-pushed
the
bnewbold/embedr-rebase
branch
from
April 13, 2024 12:24
7a8ddd6
to
ef84976
Compare
pfrazee
reviewed
Apr 13, 2024
pfrazee
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're ready to go!
estrattonbailey
added a commit
that referenced
this pull request
Apr 14, 2024
…file * origin/main: (222 commits) Release 1.77.0 (#3549) Improve the language behaviors around the PWI (#3545) fix: only close drawer if directly tapping backdrop (#3534) Fix Android in-app browser closing when switching apps (#3546) Cache DID and profile basic on profile card presses (#3523) Remove extra wrapper on notification user links (#3548) Fix hover card animation with a reducer (#3547) Update Ukrainian translation (#3537) add oEmbed links to public post HTML meta headers (#3522) rebased embedr (#3511) Increase hit slop for web's app language picker (#3535) Update Japanese translation (#3425) Fix oopsie (#3538) Fade in animation for card (#3521) [Embeds] Add ref_url (#3533) add ref_src (#3532) [Embed] Don't reuse DOM when changing embed (#3530) [Statsig] Send ref source (#3531) More obvious click area (#3528) add hideRecord prop (#3527) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
embedr
(trailing r) golang web server, similar tobskyweb
, which serves an oEmbed API endpoint, and embed HTML/assets for public embedding of Bluesky posts in other websites (aka, embedding a post in a news article or blog article).