Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French translations #3644

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

surfdude29
Copy link
Contributor

Following on from my previous PR, I have followed the same process to update the French translations.

The way labelers are described in strings is a bit inconsistent, sometimes labeler, sometimes moderation service etc. At the moment, I have simply tried to translate (with the huge help of DeepL of course 😄) the strings as they are, but now I'm thinking that perhaps aiming for more consistency would be a better approach?

Anyway, all feedback from native French speakers is gratefully welcomed – especially @Signez who was so helpful last time 🙏 Please forgive all the grammatical mistakes that I'm sure are in there, and tell me how best to fix them :)

Merci! 😊

Copy link
Contributor

@Signez Signez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First look at that translation update. Again, it's a lot of nitpicks, but there are some errors I am glad to have been able to pick up. I have to admit that I had to jump on-and-off the code quite a lot to make sure to understand how some strings were used too 😅 (it's both a good and a bad thing: it means I don't encounter them most of the time, so that's good! it also means that there are not enough i18n hints to translators, and that's quite annoying, so maybe we should take sometime at some point to improve that!)

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
@Signez
Copy link
Contributor

Signez commented Apr 22, 2024

My opinion on the étiqueteur / service d’étiquetage matter: honestly it's not that important here, as those are not humans. It matters that we translate the moderators by la modération (and not les modérateurs) because they can be humans; a labeler is more of a service that is operated by moderators, so it's not that important to translate them in a gender-neutral way.

Co-authored-by: Stanislas Signoud <[email protected]>
Copy link
Contributor Author

@surfdude29 surfdude29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much again @Signez for all your excellent corrections, I've just committed the changes 🙏

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
@@ -2013,15 +1896,15 @@ msgstr "Aller à la suite"

#: src/lib/moderation/useGlobalLabelStrings.ts:46
msgid "Graphic Media"
msgstr ""
msgstr "Médias crus"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double-check, is crus OK here? That seemed to fit the closest of the translations in the dictionary I was looking at, but maybe there's a more appropriate word?

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
@surfdude29
Copy link
Contributor Author

Again, it's a lot of nitpicks, but there are some errors I am glad to have been able to pick up.

I really appreciate all the nitpicks and the corrections! 🙏

I have to admit that I had to jump on-and-off the code quite a lot to make sure to understand how some strings were used too 😅

It's very kind of you to review it in such detail 🔍

(it's both a good and a bad thing: it means I don't encounter them most of the time, so that's good! it also means that there are not enough i18n hints to translators, and that's quite annoying, so maybe we should take sometime at some point to improve that!)

One of the things I've noticed as well is that often there can be accessibiltyHints that are virtually the same as the corresponding accessibilityLabel, and I know very little about accessibility things but I wonder how useful that really is to those who use screen readers?

And yes I agree that more of the i18n context hints would definitely be useful for translators 👍

@surfdude29 surfdude29 marked this pull request as ready for review April 22, 2024 19:11
@surfdude29
Copy link
Contributor Author

My opinion on the étiqueteur / service d’étiquetage matter: honestly it's not that important here, as those are not humans. It matters that we translate the moderators by la modération (and not les modérateurs) because they can be humans; a labeler is more of a service that is operated by moderators, so it's not that important to translate them in a gender-neutral way.

Cool, makes sense to me :)

@pfrazee
Copy link
Collaborator

pfrazee commented Apr 22, 2024

Thanks everybody. Good to go?

@Signez
Copy link
Contributor

Signez commented Apr 22, 2024

Honestly, yeah! @surfdude29 did a great job, and with the edits I suggested and that they already applied (with their awesome reactivity 👌), it looks good to me!

Or as we say in my country, 🥖🚀🥖🚀

@surfdude29
Copy link
Contributor Author

Honestly, yeah! @surfdude29 did a great job, and with the edits I suggested and that they already applied (with their awesome reactivity 👌), it looks good to me!

Or as we say in my country, 🥖🚀🥖🚀

If @Signez is happy then we're good to go! 🥖🚀🙌

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks yall!

@pfrazee pfrazee merged commit 0b3cc59 into bluesky-social:main Apr 22, 2024
6 checks passed
@surfdude29 surfdude29 deleted the update-french branch April 22, 2024 21:15
estrattonbailey added a commit that referenced this pull request Apr 23, 2024
* origin/main: (47 commits)
  Add option to remove quoted post in composer (#3670)
  Add border radius to GIF loading state (#3669)
  use mp4 over webm (#3666)
  Release 1.79 (#3661)
  Update Japanese translation (#3656)
  [Statsig] Add test gates and events (#3659)
  Quick fix to ensure disable 2fa dialog adjusts to keyboard (#3658)
  Email auth factor (#3602)
  GIF Viewer (#3605)
  Ungate profile scroll fix (#3655)
  rm country param (#3653)
  [GIFs] Remove consent flow (#3652)
  [GIFs] Replace GIPHY with Tenor (#3651)
  properly close the switch account dialog (#3558)
  [GIFs] Reset scroll on query change (#3642)
  Update French translations (#3644)
  [GIFs] Add error boundary to GIF picker (#3643)
  Revert "Add layout transitions to the composer photo gallery on iOS (#3609)" (#3649)
  Update Finnish translations  (#3630)
  Update Japanese translations (#3632)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants