Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Text field for translation in SubmitView.tsx #3738

Closed

Conversation

surfdude29
Copy link
Contributor

This small PR marks the Text field placeholder text in the report dialog for translation.

IMG_5840

@gaearon
Copy link
Collaborator

gaearon commented Apr 29, 2024

That's not a very useful label in the first place, right? Let's make it more useful.

@surfdude29
Copy link
Contributor Author

IMG_6114

Is it even necessary to have placeholder text there, given that there's already a prompt Optionally provide additional information below: ?

@pfrazee
Copy link
Collaborator

pfrazee commented May 7, 2024

Uhhh yeah that shouldn't say "Text field." Agree that, not sure it needs a placeholder.

@surfdude29 surfdude29 closed this Oct 9, 2024
@surfdude29 surfdude29 deleted the text-field-translation branch October 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants