Reduce hovercard false positives, add them to display names and handles #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3739.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-comp25uct0pc73disbig. |
gaearon
force-pushed
the
hover-on-pointermove
branch
from
246ac48 to
ef2eabd
Compare
|
|
Now that this decreases the unintentional trigger rate, I'm adding them to display names and handles. I've also bumped the threshold delay to 500ms to further reduce false positives. more.mov |
gaearon
changed the title
haileyok
reviewed
Apr 28, 2024
| @@ -244,12 +244,20 @@ export function ProfileHoverCardInner(props: ProfileHoverCardProps) { | |||
| } | |||
| }, [prefetchProfileQuery, props.did]) | |||
|
|
|||
| const onPointerEnterTarget = React.useCallback(() => { | |||
| const didFireHover = React.useRef(false) | |||
| const onPointerMoveTarget = React.useCallback(() => { | |||
| prefetchIfNeeded() | |||
There was a problem hiding this comment.
Unrelated, but this is another good use case for getting a bit more info from the API rather than just ProfileBasic. Added to a little list of "why we want this" for Wednesday.
haileyok
approved these changes
Apr 28, 2024
estrattonbailey
added a commit
that referenced
this pull request
Apr 28, 2024
* origin: Fix dropdown immediately closing on Enter (#3745) Account for momentum when hiding minimal shell (#3740) Reduce hovercard false positives, add them to display names and handles (#3739) YouTube Music as supported player (#3736) Patch lexicon for perf (#3733) ensure dialog is closed on unmount (#3650) remove precacheThreadPostProfiles (#3729) [Clipclops] New routes with placeholder screens (#3725) Special-case bsky.app/download to open share sheet or copy to clipboard (#3710) ver bump (#3731) Improve usability of search on web (#3663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of activating on pointer enter, activate on the first pointer move within.
This avoids triggering them just due to scroll. Intentionally moving the cursor still triggers it.
hover.mov