Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese translations #3886

Merged
merged 28 commits into from
May 20, 2024
Merged

Conversation

tkusano
Copy link
Contributor

@tkusano tkusano commented May 7, 2024

etc.

tkusano and others added 6 commits May 7, 2024 11:33
* Updated as PR on Plural is merged (bluesky-social#3882)
* Feedback API (bluesky-social#3498)

etc.
* Update Lightbox.tsx

* Change strings for easier localization

* Update DeleteAccount.tsx

* Update LabelsOnMeDialog.tsx

* Update FeedCard.tsx

* Update index.tsx

* Update LabelsOnMeDialog.tsx

* Update index.tsx

* Update FeedCard.tsx

* Update SelfLabel.tsx

* Update Hashtag.tsx

* Update index.tsx

* Update Hashtag.tsx

* Update ChangeHandle.tsx

* Update index.web.tsx

* Update index.web.tsx

* Update index.tsx

* Remove unnecessary `<Trans>` tags

* Update Drawer.tsx
* Update messages.po

Translated new strings (GIF's etc) and cleaned up deprecated ones.

* Update messages.po

resolve conflict

* Update messages.po

removed double quotes. Thanks @lapanti
* fix bad bool check in action

* add `fetch-depth` so we can get the commit hash

* `.env` should be in `.easignore` 🙃
Copy link
Contributor

@dolciss dolciss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for always submitting PRs for translations and for handling the plural form of #3382.
Please confirm my comment on the labeling notation shaking.

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@dolciss
Copy link
Contributor

dolciss commented May 7, 2024

Thanks for applying my comment!
LGTM

@tkusano
Copy link
Contributor Author

tkusano commented May 10, 2024

Updated translations related to following PRs

msgstr "{0, plural, other {いいねを外す (#個のいいね)}}"

#: src/view/screens/ProfileList.tsx:286
msgid "{0} your feeds"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this message untranslated until #3962 is resolved

@Hima-Zinn
Copy link
Contributor

I will check this PR tomorrow.

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@tkusano
Copy link
Contributor Author

tkusano commented May 14, 2024

@middlingphys Fixed. thanks!

Copy link
Contributor

@Hima-Zinn Hima-Zinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check.

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@pfrazee
Copy link
Collaborator

pfrazee commented May 14, 2024

Looks like there are some unresolved discussions here so Im going to hold off merging. Ping me when this is ready!

Thank you everybody! You rule!

@Hima-Zinn
Copy link
Contributor

@tkusano
Please check my review.
After that, ping pfrazee-san.

@tkusano
Copy link
Contributor Author

tkusano commented May 15, 2024

@pfrazee It looks like it didn't make it to 1.82, could you please merge this? Also, I would appreciate it if you could merge #3962 as well, as there is a message that cannot be translated.

@haileyok
Copy link
Contributor

@tkusano Got #3962 merged in for you 👍 thank all of you for this work!

@tkusano
Copy link
Contributor Author

tkusano commented May 15, 2024

@haileyok thanks!

@tkusano
Copy link
Contributor Author

tkusano commented May 16, 2024

Updated (cf. #4032 )

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@pfrazee pfrazee merged commit 8194e07 into bluesky-social:main May 20, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request May 20, 2024
* origin/main:
  Update French localization (#4113)
  Update Japanese translations (#3886)
  Update pt-BR localization to latest version (#4009)
  Update zh-CN translations (#3932)
  Update zh-TW translations  (#4025)
  Update Korean localization (#4030)
  Update catalan messages.po (#4079)
  Update Spanish Localization (#4105)
  Allow removal of feeds that fail to load (#4121)
  [🐴] Make message input layout resizing synchronous (#4123)
  [🐴] Adjust content height whenever the emoji picker keyboard is opened or closed (#4120)
  Conditionally set chat declaration (#4122)
  [🐴] Fix load state for disabled chats (#4119)
  Bump api sdk (#4118)
  [🐴] Switch back to encouraging users to report messages (#4117)
  convo button skeleton (#4115)
  [🐴] Screenreader accessibility actions for individual chat items (#4116)
  [🐴] DM button on profile (#4097)
  [🐴] Don't retry sends (#4111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants