[🐴] 🤞 This should be the final message list change - Use dispatchCommand so we don't need to know the content height
#4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4090.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp43e8n79t8c73fdaug0. |
haileyok
changed the title
dispatchCommand so we don't need to know the content height
|
simplify missing `runOnUI` better naming to avoid confusion nit remove unused function use `dispatchCommand` in `onContentSizeChanged` as well use `dispatchCommand` so we don't need to know the content height remove `isMomentumScrolling`
haileyok
force-pushed
the
hailey/list-stuff
branch
from
b807c54 to
08426d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made it in this one so that as the message input increases in height, the content scrolls up with it, looks a lot better.
Screen.Recording.2024-05-18.at.1.36.00.AM.mov