Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐴] Reset screen when pressing a DM notification while already in the conversation screen #4091

Merged
merged 2 commits into from
May 18, 2024
Merged

[🐴] Reset screen when pressing a DM notification while already in the conversation screen #4091

merged 2 commits into from
May 18, 2024

Conversation

haileyok
Copy link
Contributor

When we are already in the conversation screen, we can't just do a .navigate - it won't work! Instead, we should use reset.

@render Render
Copy link

render bot commented May 18, 2024

Your Render PR Server URL is https://social-app-pr-4091.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cp46mmun7f5s739e6lhg.

@github-actions GitHub Actions
Copy link

Old size New size Diff
6.83 MB 6.83 MB 0 B (0.00%)

mozzius
mozzius approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@haileyok haileyok merged commit 2eaecfc into main May 18, 2024
6 checks passed
@haileyok haileyok deleted the hailey/notification-while-in-chat branch May 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzius mozzius mozzius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyok @mozzius