[🐴] DM button on profile #4097
Merged
[🐴] DM button on profile #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4097.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp4grmicn0vc73dto35g. |
|
estrattonbailey
added a commit
that referenced
this pull request
May 20, 2024
* origin/main: Update French localization (#4113) Update Japanese translations (#3886) Update pt-BR localization to latest version (#4009) Update zh-CN translations (#3932) Update zh-TW translations (#4025) Update Korean localization (#4030) Update catalan messages.po (#4079) Update Spanish Localization (#4105) Allow removal of feeds that fail to load (#4121) [🐴] Make message input layout resizing synchronous (#4123) [🐴] Adjust content height whenever the emoji picker keyboard is opened or closed (#4120) Conditionally set chat declaration (#4122) [🐴] Fix load state for disabled chats (#4119) Bump api sdk (#4118) [🐴] Switch back to encouraging users to report messages (#4117) convo button skeleton (#4115) [🐴] Screenreader accessibility actions for individual chat items (#4116) [🐴] DM button on profile (#4097) [🐴] Don't retry sends (#4111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls
getProfileForMembersto decide whether or not to show the button, since you can still chat someone if they have DMs closed if you already have an ongoing chat (I set mozzius.dev tononeif you want to test). Means that it pops in after the rest of the profile but it doesn't cause layout shift. Buttons now wrap if needed, rather than flowing behind the avatar. Also includes a cleanup of the button sizes to make them all equal sizes (because before they were all different apparently????)Opted not to show on labellers, you can still message them through the new chat dialog if you really need to but I think we want to avoid the perception of labellers as normal users.