Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐴] Minor nits #4102

Merged
merged 4 commits into from
May 18, 2024
Merged

[🐴] Minor nits #4102

merged 4 commits into from
May 18, 2024

Conversation

haileyok
Copy link
Contributor

Few minor tweaks

  • Memo the chat list item
  • Set the initialNumToRender min height to something a little smaller (default is 100px but chat items are about 80px)
  • Use scrollTo with an arbitrary height to get around async scroll jank on Android

@render Render
Copy link

render bot commented May 18, 2024

Your Render PR Server URL is https://social-app-pr-4102.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cp4jpom3e1ms73cicohg.

mozzius
mozzius approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeeet

@haileyok haileyok merged commit 1ac13ab into main May 18, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

Old size New size Diff
6.83 MB 6.83 MB -66 B (-0.00%)

@haileyok haileyok deleted the hailey/messaging-nits branch June 8, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzius mozzius mozzius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyok @mozzius