-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update French localization #5227
Update French localization #5227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great translation work, again! A little bit more to say this time though. It can be summarised as:
auteur·ice
should be used instead ofaut·eur·ice
;envoyer
should be used instead oftélécharger
(when it is used as a translation ofupload
);- some other more specific stuff.
Thanks again!
Co-authored-by: Stanislas Signoud <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much again for all your corrections (and explanations) @Signez! :)
Sorry there were so many this time!
Just to double-check something: is social-app/src/locale/locales/fr/messages.po Lines 6106 to 6108 in 90682d4
social-app/src/locale/locales/fr/messages.po Lines 6750 to 6756 in 90682d4
Also, I realise that I had already translated social-app/src/locale/locales/fr/messages.po Lines 3644 to 3646 in 90682d4
|
Both are fine actually. It was not my choice in the
Good catch: sound can't be
Again, please don't ever be sorry for the amount of comments I had to make: it's always a pleasure for me to write them and it's fun to have to make explicit comments on my mother tongue 😅
Sorry if I wasn't clear, but It's the fact that it is sometimes overloaded with the |
Thanks, that's all very helpful! :) I've changed the strings to reflect it like so: social-app/src/locale/locales/fr/messages.po Lines 3644 to 3646 in 2650d68
social-app/src/locale/locales/fr/messages.po Lines 6106 to 6108 in 2650d68
social-app/src/locale/locales/fr/messages.po Lines 6750 to 6756 in 2650d68
Also, as a sidenote, I opened #5234 to ask that the labels for the social-app/src/locale/locales/fr/messages.po Lines 3571 to 3574 in 2650d68
I really appreciate all the comments, I was just a bit annoyed with myself for making so many silly mistakes 😅 Next time I think I'll give it a day or two and look at the translations again with fresh eyes before submitting the PR.
You were clear, I just didn't phrase my reply very clearly. What I was meaning to say was more like: "This one is fascinating, because I knew that
I have to admit I never would have guessed at this logic 😆 |
Great! Then I think that beside #5234, everything looks good to me. Thanks again for the amazing work 👍 |
Excellent 👌 Thanks again for your review comments! 🙏 |
Perfect, LGTM then 👍 |
Merge and update string to reflect 50MB max file size following #5245. |
I've added a translation for the new string that was added in #5273. |
Is there anything I can do to help you or the Bluesky team merging this one? I have to admit I would really like my French-speaking friends to enjoy the great work |
Paul usually merges the localization update PRs right before he cuts a release. I don't know when they're planning the next release, but I imagine it won't be all that long to wait as I'm guessing there are quite a few bugfixes and improvements to video (along with other changes) that they want to get into users' hands. You could ping him to ask him to merge it now, but even if it does get merged before a release your friend would only be able to use the updated translations on the web on the dev server (main.bsky.dev) and not on the iOS/Android app. |
Oh, right. There is no hurry to be honest (and I forgot an plural mark at "friends" in my previous comment, it was more of a general thought), it can clearly wait for a week or two. And I am sure Paul have other stuff to worry about these days 😅 |
Yeah hopefully it won't be too long to wait 🤞🦋 |
I added the new usages of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Co-authored-by: Stanislas Signoud <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All suggestions applied, thanks again! :)
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone!
Co-authored-by: Stanislas Signoud <[email protected]> (cherry picked from commit c371b70)
* origin/main: [Video] Fix safari showing spinner (#5364) [Video] Volume controls on web (#5363) Updates to Irish translation, back to 100% (#5345) Update catalan messages.po (#5223) Update Japanese translation (#5217) Update Korean localization (#5254) Update Chinese localization (#5291) Update French localization (#5227) Update Portuguese localization (#5256)
* origin/main: (113 commits) Bump 1.91.2 (#5387) [Video] Additional android fixes (#5373) Milly tweaks (#5365) [Video] Fix safari showing spinner (#5364) [Video] Volume controls on web (#5363) Updates to Irish translation, back to 100% (#5345) Update catalan messages.po (#5223) Update Japanese translation (#5217) Update Korean localization (#5254) Update Chinese localization (#5291) Update French localization (#5227) Update Portuguese localization (#5256) [Video] Fix scrubber tap target (#5360) loosen checks on vtt file (#5359) Remove overflow hidden from external link outer el (#5356) Disallow some font scaling Nux after onboarding (#5357) Fix wrong empty state for liked by (#5343) [UITextView] Add background color support to iOS selectable text (#5335) Add context to `Unmute` and `Mute` strings (#5340) ...
* origin/main: (24 commits) Fix border radius on avatars (#5392) Make like animation on web same speed as mobile (#5391) Pre-fill alt text with 10-million card post (#5389) Tweak `pt-BR` string (#5372) Bump 1.91.2 (#5387) [Video] Additional android fixes (#5373) Milly tweaks (#5365) [Video] Fix safari showing spinner (#5364) [Video] Volume controls on web (#5363) Updates to Irish translation, back to 100% (#5345) Update catalan messages.po (#5223) Update Japanese translation (#5217) Update Korean localization (#5254) Update Chinese localization (#5291) Update French localization (#5227) Update Portuguese localization (#5256) [Video] Fix scrubber tap target (#5360) loosen checks on vtt file (#5359) Remove overflow hidden from external link outer el (#5356) Disallow some font scaling ...
* remove scrollbar-gutter in fullscreen (bluesky-social#5258) * [Video] make hover state stick around if tapped (bluesky-social#5259) * increase target area of scrubber (bluesky-social#5265) * hls buffering tweaks (bluesky-social#5266) * disable autoplay within messages and trim feelers (bluesky-social#5260) * [Video] TEMP disable skip compression (bluesky-social#5271) * [Video] Cap duration (bluesky-social#5270) * fix min size for compression (bluesky-social#5272) * add (bluesky-social#5273) * [Video] Fix web autoplay (bluesky-social#5274) * make container relative (bluesky-social#5280) * remove double closing tag (bluesky-social#5257) * Add autoCapitalize to password field (bluesky-social#5216) * NUX API (bluesky-social#5278) * Set up nux API * Bump SDK * Naming * Imports * WIP * Progress on desktoip * WIP, avi not working on web * Disable avi * Add badges, clean up spacing * Copy * Don't open for logged out users * Hook up data * Rename * Refactor, integrate nux, snoozing * Fix some nux types * Dev helpers, string cleanup * Protect against 3p PDSs and bad responses * Protect against other exit methods, protect against multiple fetches * Copy * [Video] speculative .vtt file selection fix (bluesky-social#5296) * speculative vtt fix * add logging * Tabular numbers to video timestamp (bluesky-social#5293) * Fix notification scroll jump (bluesky-social#5297) * Renaming the Follow button to "Follow back" when followed by user (bluesky-social#5281) * Renaming the follow button to follow back when followed by user * Fixing conditions and reusing existing translation * Revert "Show some known OP replies in Following (bluesky-social#5049)" (bluesky-social#5301) This reverts commit bff6aed. * Add a hard-coded redirect for lulaoficial.bsky.social (bluesky-social#5303) * Add gate * Ensure dialog shows for all accounts without snoozing * Add retry * Handle overflow of bottom text * Handle display name * On android, change ten milly nux secondary action to save instead of share * Add ja and pt-BR translations * Suggested follows by actor (on profiles) updates (bluesky-social#5243) * If fallback, return nothing * Compress size a bit * Hide on own profile * Match load state * Remove gcTime * Filter out followed users * Feedback * Adjust image sizing (bluesky-social#5302) * Enable video_upload gate (bluesky-social#5311) * Fallback snoozing * Let display name wrap * Separate alt/crop, use new icon (bluesky-social#5321) * Fix notification->post jump for real (bluesky-social#5314) * Revert "Fix notification scroll jump (bluesky-social#5297)" This reverts commit e0d9e75. * Query notifications first * Image/video border + tweaks (bluesky-social#5324) * Image/video border (bluesky-social#5253) * Update AutoSizedImage.tsx * Update AutoSizedImage.tsx * Update Gallery.tsx * Update ExternalLinkEmbed.tsx * Update MediaPreview.tsx * Update UserAvatar.tsx * Update ExternalLinkEmbed.tsx * Update ExternalPlayerEmbed.tsx * Update ExternalGifEmbed.tsx * Update GifEmbed.tsx * Update ExternalGifEmbed.tsx * Update GifEmbed.tsx * Update UserAvatar.tsx * Update ExternalPlayerEmbed.tsx * Update ExternalPlayerEmbed.tsx * video * Update QuoteEmbed.tsx * Tweaks, abstract components --------- Co-authored-by: Minseo Lee <[email protected]> * Add events * Disable pointer events on media border (bluesky-social#5327) * [Video] Remove `expo-video`, use `bluesky-video` (bluesky-social#5282) Co-authored-by: Samuel Newman <[email protected]> * Fix lexicon validation in PWI Discover (bluesky-social#5329) * [Video] Remember mute state while scrolling (bluesky-social#5331) * [Video] Don't require email verification on self-host (bluesky-social#5332) * Always display next button on login page (bluesky-social#5326) Co-authored-by: Vinícius Souza <[email protected]> Co-authored-by: Hailey <[email protected]> * Apply Following settings to Lists (bluesky-social#5313) * Apply Following settings to Lists * Remove dead code * [Video] Bump video (bluesky-social#5333) * "N" keyboard shortcut to open a new post modal (bluesky-social#5197) * feat: Add hook on web app to open composer with 'N' keyboard shortcut * Extract, don't fire open composer if already open * Ignore interactive elements --------- Co-authored-by: João Gabriel <[email protected]> Co-authored-by: Hailey <[email protected]> * Don't open composer via hotkey if other dialog is already open (bluesky-social#5334) * Don't open composer via hotkey if other dialog is already open * Check for lightbox also * Check for drawer * [Video] Fix regression on audio session at launch (bluesky-social#5338) * Release 1.91.1 prep (bluesky-social#5339) * Fixes to tests * intl extract * bump (bluesky-social#5348) * Add context to `Unmute` and `Mute` strings (bluesky-social#5340) Co-authored-by: Hailey <[email protected]> * [UITextView] Add background color support to iOS selectable text (bluesky-social#5335) * Fix wrong empty state for liked by (bluesky-social#5343) * Nux after onboarding (bluesky-social#5357) * Don't show nux dialogs until post-onboarding * Don't show if over 10M * Disallow some font scaling * Remove overflow hidden from external link outer el (bluesky-social#5356) * Remove overflow hidden * Borders when no thumb * Fix overflow, add bg to no-thumb state * Cleanup * loosen checks on vtt file (bluesky-social#5359) * [Video] Fix scrubber tap target (bluesky-social#5360) * put padding on correct element * clear timeout on down * Update Portuguese localization (bluesky-social#5256) Co-authored-by: Henrique Marques <[email protected]> Co-authored-by: Arthur Tavares <[email protected]> * Update French localization (bluesky-social#5227) Co-authored-by: Stanislas Signoud <[email protected]> * Update Chinese localization (bluesky-social#5291) Co-authored-by: cirx <[email protected]> Co-authored-by: Kuwa Lee <[email protected]> * Update Korean localization (bluesky-social#5254) * Update Japanese translation (bluesky-social#5217) * Update catalan messages.po (bluesky-social#5223) Co-authored-by: surfdude29 <[email protected]> Co-authored-by: gsmt <[email protected]> * Updates to Irish translation, back to 100% (bluesky-social#5345) * [Video] Volume controls on web (bluesky-social#5363) * split up VideoWebControls * add basic slider * logarithmic volume * integrate mute state * fix typo * shared video volume * rm log * animate in/out * disable for touch devices * remove flicker on touch devices * more detailed comment * move into correct context provider * add minHeight * hack * bettern umber --------- Co-authored-by: Hailey <[email protected]> * [Video] Fix safari showing spinner (bluesky-social#5364) * Milly tweaks (bluesky-social#5365) Co-authored-by: Hailey <[email protected]> * [Video] Additional android fixes (bluesky-social#5373) * rm unused code * bump lib * invert bool * Bump 1.91.2 (bluesky-social#5387) * Tweak `pt-BR` string (bluesky-social#5372) * Pre-fill alt text with 10-million card post (bluesky-social#5389) * Pre-fill alt text with 10-million card post (bluesky-social#5377) * Clean up type * Tweak alt copy * Add pt translation, fix typo --------- Co-authored-by: Calvin <[email protected]> * Make like animation on web same speed as mobile (bluesky-social#5391) * Fix border radius on avatars (bluesky-social#5392) * Make it work with Xcode 16 (bluesky-social#5386) * Temporary Sentry hack patch for iOS 18 (bluesky-social#5400) * Revert unneeded changes to `expo-modules-core` patch (bluesky-social#5393) * remove expo-sentry (bluesky-social#5405) * Fix for undefined ref on hot reload on web (bluesky-social#5407) * Update sentry sourcemaps upload (bluesky-social#5409) * [Neue] Base (bluesky-social#5395) * Add fontScale, gate it, fix some computes * Add inter, integrate * Clean up * Apply to old Text component * Use numeric weight * Cleanup * Clean up appearance settings * Global tracking * Fix regular italic variant * Refactor settings and fontScale values * Remove flags * Get rid of lower weight font usage * Remove gate from settings * Refactor appearance settings for reuse * Add neue type nux * Update defaults * Load fonts, add fallback families * Load fonts via plugin in production * Fixes * Fix for web * Nits --------- Co-authored-by: Hailey <[email protected]> * Fix font loading on web (bluesky-social#5412) * Copy font files during build * Fall back if error loading fonts * Fix ext embeds in DMs (bluesky-social#5419) * fix ext embeds in DMs * undo acciental rounding change * Revert provider stacking changes (bluesky-social#5423) * Remove expo/vector-icons from EditImage modal (bluesky-social#5422) * [Neue] Ligatures & composer (bluesky-social#5427) * Disable contextual ligatures * Ensure new type styles are applied to the composer * Clean up using real devices * Feedback * [Neue] Copy and spacing tweaks (bluesky-social#5428) * Copy and spacing tweaks * Copy tweaks * Adjust toggle components sizing (bluesky-social#5408) (cherry picked from commit a9cbd23) * [Neue] Parallel font loading on web (bluesky-social#5411) * Parallel font loading (cherry picked from commit 10e2b05b575bbbf8b0ca5b4a336817cd902d712b) * Handle failures * Rely on font-face and preload tags for font loading (bluesky-social#5431) * Cache fonts for a year * Add eslint rule to fix imports without the `#/` path alias (bluesky-social#5175) * Add border to menu on web (bluesky-social#5439) * Language fixes (bluesky-social#5384) * Add some comments * Decouple language settings * Normalize on read/write * Refactor * Support device locale on app startup * Cleanup, port to web * Clean up comments * Comment * Try not to mutate * Protect util handling, update test * Dedupe array values * Add explicit non-handling of detached quotes in embed (bluesky-social#5156) * [Neue] Buttons (bluesky-social#5406) * Re-align button sizing (cherry picked from commit bcec243) * Use large, small, tiny (cherry picked from commit 1dc333c) * Tweaks * patch expo modules again (bluesky-social#5441) * Additional moderation (bluesky-social#5172) * Set up additional mod authorities * Filter out non-configurable mod authorities * WIP * Working * Cleanup, add mod * Cleanup * Add more debug logs * Tweak logs * Filter out imperative labels from typeaheads * Filter hideable content from notifications * Add api * Fall back in dev * Remove space * Use prod endpoint * Add tiny notice * Add notice to labeler card, show all labelers * Increase rounding for all embeds (bluesky-social#5421) * tweak image styles * fix reply image preview and covert to atoms * increase rounding on media inset border * decrease gap on desktop * fix inset styles * increase rounding on embeds to `md` * Couple edge cases --------- Co-authored-by: Eric Bailey <[email protected]> * Fixing hover card for labeler accounts (bluesky-social#5414) * Fixing hover card for labeler account * removing memo * Fixing extra spacing in notification text (bluesky-social#5396) * Validate TLD in signup (bluesky-social#5426) * add lib * add validation * log * add some common typos * add tests * reset hasWarned state on edit * shorten path * Move test file, adjust regex, add test * Get real nit picky --------- Co-authored-by: Eric Bailey <[email protected]> * Fix spacing (bluesky-social#5444) * [Neue] Font weights (bluesky-social#5442) * Align all font weights * Only load necessary fonts * Also comment out from hook --------- Co-authored-by: Samuel Newman <[email protected]> Co-authored-by: Hailey <[email protected]> Co-authored-by: Gargaj <[email protected]> Co-authored-by: Eduardo Tachotte <[email protected]> Co-authored-by: Eric Bailey <[email protected]> Co-authored-by: Minseo Lee <[email protected]> Co-authored-by: dan <[email protected]> Co-authored-by: Wesley <[email protected]> Co-authored-by: Paul Frazee <[email protected]> Co-authored-by: Vinícius Souza <[email protected]> Co-authored-by: João Gabriel <[email protected]> Co-authored-by: surfdude29 <[email protected]> Co-authored-by: Henrique Marques <[email protected]> Co-authored-by: Arthur Tavares <[email protected]> Co-authored-by: Stanislas Signoud <[email protected]> Co-authored-by: Frudrax Cheng <[email protected]> Co-authored-by: cirx <[email protected]> Co-authored-by: Kuwa Lee <[email protected]> Co-authored-by: Takayuki KUSANO <[email protected]> Co-authored-by: Ivan Beà <[email protected]> Co-authored-by: gsmt <[email protected]> Co-authored-by: Kevin Scannell <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: Roscoe Rubin-Rottenberg <[email protected]> Co-authored-by: futur <[email protected]>
Following on from #4823, this PR adds translations for new strings, removes obsolete strings and makes a few tweaks.
I'd be grateful if you could take a look @Signez 🙏