Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused extractHtmlMeta Function and Related Test Cases #5478

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

nnabeyang
Copy link
Contributor

  • Deleted extractHtmlMeta: Removed the extractHtmlMeta function, which became unused after the changes introduced in PR Use proxy for fetching link meta #716 .
  • Test Cleanup: Deleted corresponding test files and mock data from the following files:
    • exampleComHtml.ts
    • tiktokHtml.ts
    • youtubeChannelHtml.ts
    • youtubeHtml.ts
    • extractHtmlMeta.test.ts
  • Updated link-meta logic: Cleaned up references in html.ts, twitter.ts, and youtube.ts to reflect the removal of the unused function, ensuring no unnecessary code remains.

@gaearon gaearon merged commit 850cfc1 into bluesky-social:main Sep 25, 2024
6 checks passed
@nnabeyang nnabeyang deleted the delete-extract_html_meta branch September 25, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants