Add back empty placeholder #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
search-placeholder - social-app PR #5489
Render
Destroyed
|
mozzius
reviewed
Sep 25, 2024
| @@ -370,6 +370,7 @@ function SearchLanguageDropdown({ | |||
|
|
|||
| return ( | |||
| <RNPickerSelect | |||
| placeholder={{}} | |||
There was a problem hiding this comment.
You can use this to specify what the placeholder says, i.e.
placeholder={{
label: _(msg`Select language...`),
value: '',
}}
There was a problem hiding this comment.
Talked in Slack, we may want one for "No language", but need to do a little more work
haileyok
approved these changes
Sep 25, 2024
estrattonbailey
added a commit
that referenced
this pull request
Sep 26, 2024
* origin/main: Adjust line height to not cut off emoji (#5496) Emoji in account list (#5497) Make the counter more rounded (#5083) add emoji prop to composer reply to text (#5495) Fix banner height in edit profile modal (#5494) Messages list - make avatars link to profile (#5484) Add back empty placeholder (#5489) Filter errors that get sent to Sentry (#5247) Add language filtering UI to search (#5459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this we get a useless placeholder
