Paralellize image uploads #5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested review from
pfrazee,
estrattonbailey,
mozzius and
haileyok
|
arcalinea
temporarily deployed
to
embed-1 - social-app PR #5535
Render
Destroyed
arcalinea
temporarily deployed
to
embed-1 - social-app PR #5535
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to bring in different pieces inspired by / taken from #4163. The first of these pieces will be moving decoupling link meta / embed resolution from composer previews. I'm not ready to do that yet so I'm starting by doing little refactorings.
In this refactor, I'm doing a few things to the post creation method:
ascoercions. They were only needed due to how the logic was structured withembedbeing redefined to wrap the previousembed.embeda bit difficult to trace in general because it wasn't clear which cases are mutually exclusive. I've refactored it with stronger types to actually follow the codepaths that can execute.Test Plan
Verify all of these still work.