[Sheets] [Pt. 2] Remove a bunch of now-unnecessary things #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
hailey/dialogs-pt2 - social-app PR #5560
Render
Destroyed
|
haileyok
force-pushed
the
hailey/dialogs-pt2
branch
from
6296f5e to
6dec099
Compare
haileyok
commented
Oct 2, 2024
Comment on lines
+46
to
+57
| if (isWeb) { | ||
| openDialogs.current.forEach(id => { | ||
| const dialog = activeDialogs.current.get(id) | ||
| if (dialog) dialog.current.close() | ||
| }) | ||
|
|
||
| return openDialogs.current.size > 0 | ||
| } else { | ||
| // @TODO DIALOGS REFACTOR | ||
| console.error('HAILEY FIX THIS 🥺📋') | ||
| return false | ||
| } |
There was a problem hiding this comment.
I still need to come back to this. I believe this will be unnecessary now (on all platforms?) since my understanding is it was used to fix the android back button (which is just handled natively now, no need for us to pay attention to it.)
haileyok
commented
Oct 2, 2024
| @@ -22,8 +22,6 @@ type Props = { | |||
| export const ImageAltTextDialog = (props: Props): React.ReactNode => { | |||
| return ( | |||
| <Dialog.Outer control={props.control}> | |||
| <Dialog.Handle /> | |||
There was a problem hiding this comment.
Removing all Handles, because the native dialog includes a handle on both platforms.
haileyok
commented
Oct 2, 2024
Comment on lines
+44
to
+45
| // @TODO DIALOG REFACTOR - can i get rid of this? seems pointless tbh | ||
| const [isOpen, setIsOpen] = React.useState(false) |
There was a problem hiding this comment.
This ended up getting removed later since it isn't useful.
mozzius
approved these changes
Oct 2, 2024
arcalinea
temporarily deployed
to
hailey/dialogs-pt2 - social-app PR #5560
Render
Destroyed
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog.Handleuses