-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sheets] [Pt. 13] Keyboard handling #5586
Merged
Merged
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
5a98ea6
Include ghost hook to statically export fonts (#5553)
estrattonbailey 801cb62
close all dialogs
haileyok a17892d
remove a bunch of to-be-useless stuff
haileyok 3971254
remove `Dialog.Handle` uses
haileyok 64f849b
rm handle component
haileyok 6dec099
type
haileyok d0149a9
get scrollview working
haileyok 40030ba
tidy
haileyok 0b55acd
bump
haileyok 368a9df
bump gesture handler
haileyok a4c7e2f
tweak types
haileyok e1ccacc
add props back
haileyok b900ac6
update types
haileyok baf1923
update other dialog views
haileyok a3737f0
replace all buttons with `BottomSheetButton`
haileyok e2f8e7c
fix type
haileyok 81906df
wizard remove buttons
haileyok cdfdf49
fix
haileyok 8bd6b2d
fix embed consent
haileyok 65bfd89
buttons in account switcher
haileyok 87c83dd
custom bottom sheet link
haileyok 5a60190
nesting support
haileyok f251a43
Add intent/verify-email to go server (#5554)
estrattonbailey 3569873
Tweak verify email dialog (#5555)
estrattonbailey 1a7885b
Add suspense boundary in onboarding (#5556)
estrattonbailey d4b8401
android support
haileyok 1ca6d36
fix type
haileyok a444fc5
import order (#5571)
haileyok 3972d3d
Ignore built files (#5572)
estrattonbailey 4059668
Make reply prompt more subtle on desktop (#5569)
mozzius b5a5113
simplify pressable changes
haileyok 349b8b7
rm
haileyok 1ea82c3
rename for clairity
haileyok f558eb6
fix other buttons in dialogs
haileyok f365ae0
tweak
haileyok ca0888c
more fixes
haileyok 43eb47f
Merge remote-tracking branch 'origin/main' into hailey/dialogs-pt10
haileyok 13c9c79
move files around (#5576)
mozzius c2dac85
Delete messages NUX (#5574)
mozzius 1357ac3
bump
haileyok 3fabcc2
revert some changes
haileyok 1ad73e1
Merge remote-tracking branch 'origin/hailey/dialogs-pt1' into hailey/…
haileyok b0c0aee
custom bottom sheet link
haileyok 84d32e3
simplify pressable changes
haileyok 5fe4ee9
rm
haileyok 839d6dc
rename for clairity
haileyok 1d5a3ef
tweak
haileyok 6d7b54c
fix namE
haileyok 10cb87b
use context to pick default pressable component
haileyok 431f1ff
adjust
haileyok fee2468
Merge branch 'hailey/dialogs-pt7-rework' into hailey/dialogs-pt8
haileyok bb33aa0
revert all the button import changes
haileyok 67e4d77
revert all the changes that are not needed'
haileyok 7ef51ac
Merge branch 'hailey/dialogs-pt8' into hailey/dialogs-pt9
haileyok 1bda59c
Merge branch 'hailey/dialogs-pt9' into hailey/dialogs-pt10
haileyok 5c36d8c
remove unused type
haileyok 24bebec
Merge remote-tracking branch 'origin/main' into hailey/dialogs-pt10
haileyok d007151
move into repo
haileyok 2ac8308
lint
haileyok 52532fb
add config
haileyok 2b98055
update type imports
haileyok 7ee865f
fix import
haileyok 7489a70
add event to ios
haileyok 0ce5d44
simplify logic
haileyok b6adc93
ensure event fires on open
haileyok 086dde7
log
haileyok 83d1c38
Allow default PressableComponent override
estrattonbailey 639a7ea
fix accessibility
haileyok 8295c23
before spread
haileyok b64a294
clean
haileyok 97c5053
implement keyboard handling
haileyok 1c14991
rm now useless components
haileyok c6d7a5f
Merge remote-tracking branch 'origin/hailey/dialogs-pt1' into hailey/…
haileyok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,6 @@ import {AppBskyLabelerDefs} from '@atproto/api' | |
import {atoms as a} from '#/alf' | ||
import * as Dialog from '#/components/Dialog' | ||
import {useDelayedLoading} from '#/components/hooks/useDelayedLoading' | ||
import {useOnKeyboardDidShow} from '#/components/hooks/useOnKeyboard' | ||
import {Loader} from '#/components/Loader' | ||
import {Text} from '#/components/Typography' | ||
import {SelectLabelerView} from './SelectLabelerView' | ||
|
@@ -39,9 +38,6 @@ function ReportDialogInner(props: ReportDialogProps) { | |
const isLoading = useDelayedLoading(500, isLabelerLoading) | ||
|
||
const ref = React.useRef<ScrollView>(null) | ||
useOnKeyboardDidShow(() => { | ||
ref.current?.scrollToEnd({animated: true}) | ||
}) | ||
Comment on lines
-42
to
-44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No longer needed 🥹 |
||
|
||
return ( | ||
<Dialog.ScrollableInner label={_(msg`Report dialog`)} ref={ref}> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of a vibe based number. Feels good though, nice bit of padding.