Make composer reducer source of truth for images/video when publishing #5595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Oct 3, 2024
| setCaptions: React.Dispatch< | ||
| React.SetStateAction<{lang: string; file: File}[]> | ||
| > | ||
| setCaptions: (updater: (prev: CaptionsTrack[]) => CaptionsTrack[]) => void |
There was a problem hiding this comment.
this is slightly more narrow than the previous type because we only use the setCaptions(state -> state) signature.
|
gaearon
changed the title
gaearon
force-pushed
the
embed-6
branch
2 times, most recently
from
5e84c04 to
b22f320
Compare
estrattonbailey
approved these changes
Oct 4, 2024
arcalinea
temporarily deployed
to
embed-6 - social-app PR #5595
Render
Destroyed
estrattonbailey
added a commit
that referenced
this pull request
Oct 4, 2024
* origin/main: Make composer reducer source of truth for images/video when publishing (#5595) Track links and embeds in the composer reducer (#5593) Bump SDK (#5602) Update built asset caching (#5601) Downgrade sentry to recommended 5.24.3 (#5604) Add option to search in any language (#5598) Font tweaks (#5597)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #5593 although unrelated.
The first commit moves remaining video-related state into the video reducer.
The second commit finally makes the
composerStatesource of truth for the publish function — although for now, in a limited way. Only images and videos are being read from there. We're going to be moving more things over there soon.Test Plan
For first commit, upload video, verify you can edit alt text. Add some subtitles (like this file). Verify they show up after posting. Verify they clear after removing and readding a video.
For second commit, verify that generally posting images and videos works like before.