Split GifEmbed props

[gaearon]

This would help me in an upcoming refactor. Just splitting the props so it doesn't always accept the whole link object.

Test Plan

Verify GIFs with explicit ALT and implicit ALT still show up (and both have alt in DOM, but only explicit one shows badge).

Verify editor still works.

[gaearon]

Note these can just be altText and true now because we're always passing down the "preferred" version. (In any case they don't really matter because it's a preview and has hideAlt. Arguably maybe it shouldn't get any alt at all.)

[github-actions]

Old size	New size	Diff
7.92 MB	7.92 MB	228 B (0.00%)

---

[surfdude29]

Verify GIFs with explicit ALT and implicit ALT still show up (and both have alt in DOM, but only explicit one shows badge).

Until I just saw this, I was under the mistaken impression that GIFs that didn't display the ALT badge didn't have alt in DOM, so it's good to know that they actually do.

Given that this might be confusing other people too (see #4918), is it planned as part of your refactor to show the badge for GIFs with implicit ALT too? I think this would be helpful and less confusing for users.

[surfdude29]

Also, while you're working on the GIF alt composer, would it be possible to squeeze in a fix for #4225? 🙏

(although it's possible that's already been fixed on iOS by #5611?)

[gaearon]

This PR is really a drive-by refactor for unrelated things I'm working on so I'm not taking a super close look at how it behaves.

Given that this might be confusing other people too (see #4918), is it planned as part of your refactor to show the badge for GIFs with implicit ALT too?

With the behavior currently in main, it won't show the badge until you open the "alt" popup, but once you do (and close it), that alt will be considered explicit. Which is slightly confusing in a different way but probably ok.

[gaearon]

Meh I'll just roll it all into one PR.

[surfdude29]

This PR is really a drive-by refactor for unrelated things I'm working on so I'm not taking a super close look at how it behaves.

Ah fair enough 👍

Given that this might be confusing other people too (see #4918), is it planned as part of your refactor to show the badge for GIFs with implicit ALT too?

With the behavior currently in main, it won't show the badge until you open the "alt" popup, but once you do (and close it), that alt will be considered explicit. Which is slightly confusing in a different way but probably ok.

Yeah the behavior on main is a big improvement over 1.91.1.