Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclose the entire message in Trans tags for translation #5616

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

tkusano
Copy link
Contributor

@tkusano tkusano commented Oct 5, 2024

Recent modifications to the label-related code complicated the translation work for languages with word orders different from English. To address this, I made a patch to enclose the entire sentence within a Trans tag.

@tkusano
Copy link
Contributor Author

tkusano commented Oct 5, 2024

see comments from @quiple in #5557

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Definitely should have reverted that change on my end, appreciate you finding it and cleaning it up 🙏. Thought we were going to need to break this up but things worked out so we don't have to.

Works on both iOS and Android.

@haileyok haileyok merged commit 1118fd6 into bluesky-social:main Oct 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants