Display non-post embeds in composer preview #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Oct 8, 2024
|
gaearon
force-pushed
the
embed-others-2
branch
from
246a7cd to
5c4ff8b
Compare
gaearon
force-pushed
the
embed-other-3
branch
2 times, most recently
from
cc0147b to
65c9735
Compare
estrattonbailey
approved these changes
Oct 24, 2024
gaearon
force-pushed
the
embed-others-2
branch
from
5c4ff8b to
ed8125f
Compare
This should not be needed because starter pack composer preview now goes through the record preview codepath, just like in the feed/post view.
Remove the implicit top padding in record embeds and make it conditional, which is similar to how we treat external link embeds. This makes the X button appear in the same place for record embeds as with links.
gaearon
force-pushed
the
embed-other-3
branch
from
65c9735 to
1bd55e6
Compare
arcalinea
temporarily deployed
to
embed-other-3 - social-app PR #5647
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5608 (review).
This finally adds previews for non-post records. Including fixing the special case (presence of quote will now correctly hide post record previews since they won't actually make it to the post.)
The "X" button is not aligned perfectly for all cases, feel free to edit it up.Fixed.Note that https://go.bsky.app/* links don't currently go through this codepath in development because
resolveShortLinkdoesn't work in development. So if you try that one, you should see a regular link preview. It looks almost the same tho.Test Plan