Move Dialogs to Radix #5648
Merged
Move Dialogs to Radix #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Redix FocusTrap * force resolutions on radix libs * add focus guards * use @radix-ui/dismissable-layer for escape handling * fix banner menu keypress by using `Pressable` * add menu in dialog example to storybook --------- Co-authored-by: Samuel Newman <[email protected]>
estrattonbailey
approved these changes
Oct 8, 2024
| @@ -90,14 +93,11 @@ export function UserBanner({ | |||
|
|
|||
| // setUserBanner is only passed as prop on the EditProfile component | |||
| return onSelectNewBanner ? ( | |||
| <EventStopper onKeyDown={false}> | |||
| <EventStopper onKeyDown={true}> | |||
There was a problem hiding this comment.
Not sure we even need this anymore
There was a problem hiding this comment.
oh cool! I'll follow up with a PR to remove those, wanna test thoroughly first so won't do it here
haileyok
reviewed
Oct 8, 2024
| @@ -10,7 +10,9 @@ import { | |||
| import Animated, {FadeIn, FadeInDown} from 'react-native-reanimated' | |||
| import {msg} from '@lingui/macro' | |||
| import {useLingui} from '@lingui/react' | |||
| import {FocusScope} from '@tamagui/focus-scope' | |||
There was a problem hiding this comment.
Can we remove this library now?
arcalinea
temporarily deployed
to
samuel/dialog-menu-nesting - social-app PR #5648
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Radix's
focus-scopeandfocus-guardutilities to the dialogs and composer, so that they can compose properly with the dropdown menus. This means that dialogs and menus can now be nested, and theEscapekey will work properly.I also did the same to the composer, so now focus loops around when you get to the end
I also added nested sheet support to the menu component on native
Test plan
Dialog with menu in itbutton in the Storybook (all platforms). Before these changes, this would've caused a recursion bug on firefox, so make sure that doesn't happen