Downgrade Radix packages for type compat #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
dropdown-types - social-app PR #5653
Render
Destroyed
arcalinea
temporarily deployed
to
dropdown-types - social-app PR #5653
Render
Destroyed
haileyok
approved these changes
Oct 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zeego depends on Radix even though we don't use Zeego's Radix abstraction. I think something in this Radix update changed types, and this upgraded version of
react-dropdown-menuwas causing unusual type errors e.g.prop 'style' does not exist on ...<props>, even though it continued working.Looking through the git history, I don't think we really need these updated versions, or to update resolutions to point to those latest versions.
After downgrading, there was still an error with
DropdownMenuContentwhere it thought optional props from Radix'sPopoverabstraction were required. But this was appearing on the native component, where Radix is not used.So types got a little funky here somewhere, but the only override needed is for the native component, where it shouldn't matter 👍