-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email verification prompts throughout the app #6174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haileyok
force-pushed
the
hailey/email-verif
branch
from
November 9, 2024 01:25
f236778
to
94a7cc1
Compare
|
arcalinea
temporarily deployed
to
hailey/email-verif - social-app PR #6174
November 11, 2024 23:24 — with
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/email-verif - social-app PR #6174
November 12, 2024 00:26 — with
Render
Destroyed
mozzius
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I couldn't find any way to get past the prompts
haileyok
added a commit
that referenced
this pull request
Nov 16, 2024
(cherry picked from commit 427f3a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This adds "checkpoints" for email verification to the frontend of the application. We want to start requiring email verification to perform:
Test Plan
Email verification should be required in the places listed above. Need to check every entry point. Particularly, for DMs make sure that you get prompted to verify email when:
Other features need to have their entryways checked too. I think I found all the places where we have "new list" buttons, but I might have missed an entry point.