Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email verification prompts throughout the app #6174

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Nov 8, 2024

Why

This adds "checkpoints" for email verification to the frontend of the application. We want to start requiring email verification to perform:

  • Creation of a post, including replies
  • Creation of moderation lists
  • Creation of curate lists
  • Creation of starter packs
  • Messaging other users

Test Plan

Email verification should be required in the places listed above. Need to check every entry point. Particularly, for DMs make sure that you get prompted to verify email when:

  • Pressing the "chat" button on a user's profile
  • Pressing the FAB button on the chat screen
  • Opening a conversation directly (i.e. on web via URL)

Other features need to have their entryways checked too. I think I found all the places where we have "new list" buttons, but I might have missed an entry point.

Copy link

github-actions bot commented Nov 9, 2024

Old size New size Diff
8.01 MB 8.01 MB 2.88 KB (0.04%)

@arcalinea arcalinea temporarily deployed to hailey/email-verif - social-app PR #6174 November 11, 2024 23:24 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/email-verif - social-app PR #6174 November 12, 2024 00:26 — with Render Destroyed
@haileyok haileyok marked this pull request as ready for review November 12, 2024 00:27
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I couldn't find any way to get past the prompts

@haileyok haileyok merged commit 427f3a8 into main Nov 12, 2024
6 checks passed
haileyok added a commit that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants