Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase copied animation lingering time for reduced motion #6220

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

khuddite
Copy link
Contributor

@khuddite khuddite commented Nov 11, 2024

Fixes #6199

  1. Summary
    When reduced motion is enabled via accessibility settings on desktop/mobile devices, copied animation stays for 0.1 sec, and it disappears too fast. It happens because entering/exit animations are disabled by the react-native-reanimated library by default for reduced motion.
  2. Solution
    We can constantly enable entering/exiting animations regardless of reduced motion settings and adjust their parameters if we want. But I kept them enabled for now and increased the Copied label lingering time from 0.1 sec to 2 sec. Please advise if we want to follow a different path from a UX perspective.
    Here is what it looks like -
    https://github.com/user-attachments/assets/d7d9dc8c-4f3e-4e8a-8c55-b3c5e78a3a07

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable!

@gaearon gaearon merged commit 57464a8 into bluesky-social:main Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copied notice on app passwords doesn't take reduced motion into account
2 participants