Fix error state of lists of not taking the full height

[khuddite]

Fixes #6226

1. Summary
   It seems there was an inconsistency between the loading state and error/empty state styles in the code. Specifically, the loading state has a.h_full_vh, whereas error/empty state doesn't. Instead, it has a.flex_1 which sets the view height to its content height.

2. Solution
   Updated Error component to have a.h_full_vh in its style.

3. Screenshots
   
   

[gaearon]

is this for the same issue as #6235 or a different one?

[khuddite]

is this for the same issue as #6235 or a different one?

I'd say they are not necessarily the same, but they are definitely related. I was actually about to test my changes on mobile devices, but I couldn't quite figure out how to navigate to the reposted by screen from the post screen.

But for now, it seems we need to get rid of a.flex_1 and add both a.w_full and a.h_full_vh.

I can investigate more if someone can help me navigate to Reposted by screen on mobile.

[khuddite]

Alright, so I was able to debug it on my real Android device via deep link. It seems we don't necessarily need a.w_full to fix the issue #6235 is supposed to fix. Just removing a.flex_1 will fix the issue. Actually, I think not adding it will be better for consistency because the loading state doesn't have that style either.

social-app/src/components/Lists.tsx

Line 179 in 57464a8

<CenteredView

However, it's required to add a.h_full_vh style for this PR to fix the reported issue. And that aligns with the error state styles because it has a.h_full_vh, too.

So, in summary, I think having a.flex_1 was a mistake in the first place, and that should be replaced with a.h_full_vh to fix both issues. And #6235 can be closed in favor of this PR.

This is what the mobile empty state looks like on this PR, and it seems to be the desired behavior.

[khuddite]

I seems this PR has a conflict now, and it needs to be rebased off of the main branch. However, if I force push after rebase, I believe it will clear the chat history. Please advise what's the best way to deal with it. Thanks!

[mozzius]

Hi - just rebase, I'm happy to merge this once there are no conflicts!

[khuddite]

I am sorry, but I am not really familiar with git rebase. It seems merge conflicts are already gone.

Please advise if there is anything left for me to do.

Is it okay to rebase off of upstream/main, resolve conflicts and force-push it to keep the git graph clean?

[mozzius]

no I just fixed the conflicts manually! nothing to do. thanks for the contribution!